[PATCH] D20541: [esan|cfrag] Create the skeleton of cfrag variable for the runtime

Qin Zhao via llvm-commits llvm-commits at lists.llvm.org
Fri May 27 15:39:29 PDT 2016

zhaoqin marked an inline comment as done.

Comment at: lib/Transforms/Instrumentation/EfficiencySanitizer.cpp:266
@@ +265,3 @@
+  // struct ToolInfo {
+  //   const char *UnitName;
+  // };
bruening wrote:
> This seems to be a compromise that does not seem ideal: now we have two structs with the same field that is duplicated instead of shared.  I would say, either go back to the original CL and pass nullptr here, or share this field via a contained struct or an anonymous generated struct sharing that field code (that approach seems to have been tried and rejected though).
create a nullptr instead.


More information about the llvm-commits mailing list