[PATCH] D20664: [ELF][MIPS] Always resolve MIPS GP-relative relocations to 'local' definitions

Simon Atanasyan via llvm-commits llvm-commits at lists.llvm.org
Fri May 27 14:07:44 PDT 2016


atanasyan updated this revision to Diff 58835.
atanasyan added a comment.

Use stricter condition in the `isPreemptible`. Now we check on R_MIPS_GPREL16 relocation only because only this relocation can be against preemptible symbol and should be resolved locally. The side effect - `isPreemptible` routine becomes more complicated with a long comment describes handling 3-in-1 MIPS relocation packs.

Still LGTM?


Repository:
  rL LLVM

http://reviews.llvm.org/D20664

Files:
  ELF/Relocations.cpp
  test/ELF/mips-64-gprel-so.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D20664.58835.patch
Type: text/x-patch
Size: 4002 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160527/b4a0678c/attachment.bin>


More information about the llvm-commits mailing list