[PATCH] D20724: [pdb] Apply zero-copy algorithms to symbol stream iteration

Zachary Turner via llvm-commits llvm-commits at lists.llvm.org
Fri May 27 10:19:09 PDT 2016


zturner updated this revision to Diff 58805.
zturner added a comment.

Don't use a traits class, instead specify ValueType and extraction functor as separate template arguments.

Following the pattern of STL data structures like `std::map`, I've specified a default value for the extraction functor, so if you define a specialization of this template, you don't need to pass the second argument.


http://reviews.llvm.org/D20724

Files:
  include/llvm/DebugInfo/CodeView/CVSymbolVisitor.h
  include/llvm/DebugInfo/CodeView/CVTypeVisitor.h
  include/llvm/DebugInfo/CodeView/RecordIterator.h
  include/llvm/DebugInfo/CodeView/StreamArray.h
  include/llvm/DebugInfo/CodeView/StreamReader.h
  include/llvm/DebugInfo/CodeView/SymbolDumper.h
  include/llvm/DebugInfo/CodeView/SymbolRecord.h
  include/llvm/DebugInfo/CodeView/TypeDumper.h
  include/llvm/DebugInfo/PDB/Raw/DbiStream.h
  include/llvm/DebugInfo/PDB/Raw/ModInfo.h
  include/llvm/DebugInfo/PDB/Raw/ModStream.h
  lib/DebugInfo/CodeView/SymbolDumper.cpp
  lib/DebugInfo/CodeView/TypeDumper.cpp
  lib/DebugInfo/PDB/Raw/DbiStream.cpp
  lib/DebugInfo/PDB/Raw/ModInfo.cpp
  lib/DebugInfo/PDB/Raw/ModStream.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D20724.58805.patch
Type: text/x-patch
Size: 17168 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160527/3b09a890/attachment.bin>


More information about the llvm-commits mailing list