[PATCH] D20664: [ELF][MIPS] Always resolve MIPS GP-relative relocations to 'local' definitions
Simon Atanasyan via llvm-commits
llvm-commits at lists.llvm.org
Fri May 27 09:29:23 PDT 2016
On Fri, May 27, 2016 at 7:22 PM, Rafael Espíndola
<rafael.espindola at gmail.com> wrote:
> On May 27, 2016 12:18 PM, "Simon Atanasyan" <simon at atanasyan.com> wrote:
>> R_MIPS_GPREL32 is for local symbols. But GNU linker does not show any
>> error if R_MIPS_GPREL32's target is preemptible symbol. So I still think it
>> is better to handle them uniformly too.
> If it doesn't show up in the wild, please don't check for it.
Do you suggest to check for relocation type R_MIPS_GPREL16 not for
relocation expression R_GOTREL in the new isPreemptible routine?
More information about the llvm-commits