[PATCH] D20455: [asan] Enable asan Win64 build

[Etienne Bergeron via llvm-commits]

etienneb added a comment.

I tested the patch on my windows machine, and it's working fine.
I'm running unittests on linux.

Could you please fix the remaining nits and I'll land this.


================
Comment at: lib/asan/asan_win.cc:73
@@ -63,1 +72,3 @@
 
+// TODO(wwchrome@): Win64 has no _except_handler3/4.
+// Need to implement _C_specific_handler instead.
----------------
no @

================
Comment at: lib/asan/asan_win.cc:156
@@ +155,3 @@
+
+// TODO(wwchrome@): Win64 uses _C_specific_handler instead.
+#ifndef _WIN64
----------------
There is no "@" here.

================
Comment at: lib/interception/interception_win.cc:72
@@ +71,3 @@
+#ifdef _WIN64
+  // TODO(wwchrome@): Implement similar logic for x64 instructions.
+  // Win64 RoundUpToInstrBoundary is not supported yet.
----------------
no @

================
Comment at: lib/interception/interception_win.cc:154
@@ -146,3 +153,3 @@
 #ifdef _WIN64
-#error OverrideFunction is not yet supported on x64
-#endif
+  // TODO(wwchrome@): Implement using x64 jmp.
+  // OverrideFunction is not yet supported on x64.
----------------
no @

================
Comment at: test/asan/CMakeLists.txt:6
@@ -5,1 +5,3 @@
 
+# TODO: Re-enable Win64 asan tests when ready.
+# Disable tests for asan Win64 temporarily.
----------------
missing (wwchrome)

================
Comment at: test/asan/CMakeLists.txt:126
@@ +125,3 @@
+
+# TODO: Re-enable the tests for asan Win64 when ready.
+if(NOT OS_NAME MATCHES "Windows" OR CMAKE_SIZEOF_VOID_P EQUAL 8)
----------------
ditto

================
Comment at: test/ubsan/CMakeLists.txt:35
@@ -34,2 +34,3 @@
   if(COMPILER_RT_HAS_ASAN AND ";${ASAN_SUPPORTED_ARCH};" MATCHES ";${arch};")
-    add_ubsan_testsuite("AddressSanitizer" asan ${arch})
+    # TODO: Re-enable ubsan for asan win 64-bit when ready.
+    # Disable ubsan with AddressSanitizer tests for Windows 64-bit.
----------------
ditto


http://reviews.llvm.org/D20455