[PATCH] D20664: [ELF][MIPS] Always resolve MIPS GP-relative relocations to 'local' definitions

Rafael Ávila de Espíndola via llvm-commits llvm-commits at lists.llvm.org
Fri May 27 07:05:21 PDT 2016

rafael accepted this revision.
rafael added a comment.
This revision is now accepted and ready to land.

So, while this should work, it fairly undesirable that preemption depends on the relocation.

Any idea why gpword is used with a global? The comment in the MC parser implies it should be used with a local:

/// parseDirectiveGpWord
///  ::= .gpword local_sym

Also, llvm doesn't seem to print it for anything but jump tables.

So, long way of saying LGTM, but please add a fixme about dropping this once freebsd moves out of the prehistorical gcc.



More information about the llvm-commits mailing list