[llvm] r270956 - [Support] Remove a stale comment.

Rafael EspĂ­ndola via llvm-commits llvm-commits at lists.llvm.org
Fri May 27 03:03:57 PDT 2016


This is still a bit confusing. If it is not to be used programmatically,
why the error code?
On May 26, 2016 10:49 PM, "Lang Hames via llvm-commits" <
llvm-commits at lists.llvm.org> wrote:

> Author: lhames
> Date: Thu May 26 21:43:15 2016
> New Revision: 270956
>
> URL: http://llvm.org/viewvc/llvm-project?rev=270956&view=rev
> Log:
> [Support] Remove a stale comment.
>
> This comment was included in Peter Collingbourne's original version of
> StringError (see http://reviews.llvm.org/D20550), where it made sense. It
> was
> accidentally copied over with the rest of the class, but no longer applies.
>
>
> Modified:
>     llvm/trunk/include/llvm/Support/Error.h
>
> Modified: llvm/trunk/include/llvm/Support/Error.h
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Support/Error.h?rev=270956&r1=270955&r2=270956&view=diff
>
> ==============================================================================
> --- llvm/trunk/include/llvm/Support/Error.h (original)
> +++ llvm/trunk/include/llvm/Support/Error.h Thu May 26 21:43:15 2016
> @@ -886,8 +886,7 @@ template <typename T> ErrorOr<T> expecte
>  ///
>  /// StringError is useful in cases where the client is not expected to be
> able
>  /// to consume the specific error message programmatically (for example,
> if the
> -/// error message is to be presented to the user). It cannot be converted
> to a
> -/// std::error_code.
> +/// error message is to be presented to the user).
>  class StringError : public ErrorInfo<StringError> {
>  public:
>    static char ID;
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160527/cfe72f1d/attachment.html>


More information about the llvm-commits mailing list