[PATCH] D20706: [LibFuzzer] Refactor declaration of tests in CMake.

[Dan Liew via llvm-commits]

delcypher added a comment.

In http://reviews.llvm.org/D20706#441867, @kcc wrote:

> LGTM, assuming this does not change the behavior of 'check-fuzzer'.
>  I wonder, how you can verify that.
>  In the past I remember cmake changes that caused us to not run some tests.
>  We've learned about those in a hard way...
>
> > > They used to take ~40 seconds on my machine now it takes roughly ~140 seconds. Is that intentional?
>
> > 
>
>
> Not intentional... On my box they still take 25 seconds...


Okay FYI the slow down is introduced in r270942. For that commit if I run

  bin/llvm-lit lib/Fuzzer/test/fuzzer.test
  -- Testing: 1 tests, 1 threads --
  PASS: LLVMFuzzer :: fuzzer.test (1 of 1)
  Testing Time: 126.83s
    Expected Passes    : 1

on the previous commit

  bin/llvm-lit lib/Fuzzer/test/fuzzer.test
  -- Testing: 1 tests, 1 threads --
  PASS: LLVMFuzzer :: fuzzer.test (1 of 1)
  Testing Time: 3.63s
    Expected Passes    : 1

My configure line is

  CC=/home/dan/dev/llvm-upstream/ninja_build/bin/clang CXX=/home/dan/dev/llvm-upstream/ninja_build/bin/clang++ cmake -DCMAKE_BUILD_TYPE=RELWITHDEBINFO  -DLLVM_USE_SANITIZER=Address -DLLVM_USE_SANITIZE_COVERAGE=YES  ../src/ && make check-fuzzer -j8

and the clang I'm building with is clang version 3.9.0 (trunk 270188) which is a bit old. I should probably rebuild clang and see if this is still observable.


http://reviews.llvm.org/D20706