[PATCH] D20717: pdbdump: print out COFF section headers.

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Thu May 26 18:53:31 PDT 2016


ruiu created this revision.
ruiu added a reviewer: zturner.
ruiu added a subscriber: llvm-commits.

Unlike other sections that can grow to any size, the COFF section header
stream has maximum length because each record is fixed size and the COFF
file format limits the maximum number of sections. So I decided to not
create a specific stream class for it. Instead, I added a member function
to PDBFile class which returns a vector of COFF headers.

I think it is enough, but I'm open to other options, so let me know if
you think the other way.

http://reviews.llvm.org/D20717

Files:
  include/llvm/DebugInfo/PDB/Raw/PDBFile.h
  lib/DebugInfo/PDB/Raw/PDBFile.cpp
  test/DebugInfo/PDB/pdbdump-headers.test
  tools/llvm-pdbdump/llvm-pdbdump.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D20717.58741.patch
Type: text/x-patch
Size: 10555 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160527/6ec09f94/attachment.bin>


More information about the llvm-commits mailing list