[PATCH] D20453: Remove optnone/opt-bisect check from StackColoring

Paul Robinson via llvm-commits llvm-commits at lists.llvm.org
Thu May 26 16:49:10 PDT 2016

probinson added a comment.

In http://reviews.llvm.org/D20453#441677, @thanm wrote:

> Hi Andy,
>  I think I agree with probinson about the need for removing the markers in the opt-none case. I think the most expedient thing to do would be to make the skipFunction() check at the same point in the code where "DisableColoring" is checked (line 1008), this way the "removeAllMarkers()" helper will be called on the way out. This has the minor compile-time drawback that there is some analysis done to get to this point, but that seems like a minor concern for bisections purposes. 
>  Thanks, Than

I like Than's idea.  For either bisection or optnone, the compile-time "drawback" is pretty irrelevant.



More information about the llvm-commits mailing list