[PATCH] D20550: Linker: error_code'ify the IR mover. NFC.

Lang Hames via llvm-commits llvm-commits at lists.llvm.org
Thu May 26 16:30:32 PDT 2016


lhames added a comment.

Mostly looks good, but StringError as-is would be dangerous as a general utility  - conversion is impossible but we're unlikely to spot that during development because we're bad at testing error cases. Instead there'll be UB out in the wild when we hit it.

Let me fix up the indescribable error stuff that I've got and commit a safer version of StringError that uses it.


http://reviews.llvm.org/D20550





More information about the llvm-commits mailing list