[PATCH] D20649: [X86] Add a pattern that uses GR16_ABCD rather than GR32_ABCD to avoid falsely marking whole 32 bit register as live.

Quentin Colombet via llvm-commits llvm-commits at lists.llvm.org
Thu May 26 16:22:58 PDT 2016

qcolombet added inline comments.

Comment at: test/CodeGen/X86/i16lshr8pat.ll:1
@@ +1,2 @@
+; RUN: llc -march=x86 -print-after=expand-isel-pseudos <%s 2>&1 | FileCheck %s
If you use print-after, I think you need to have an assert build.
Also given what you are checking, wouldn’t the mir test be robust enough?
I mean we do not need to check for the subreg index, do we?


More information about the llvm-commits mailing list