[PATCH] D20550: Linker: error_code'ify the IR mover. NFC.

Peter Collingbourne via llvm-commits llvm-commits at lists.llvm.org
Thu May 26 15:30:45 PDT 2016

On Tue, May 24, 2016 at 5:09 PM, Rafael EspĂ­ndola <
rafael.espindola at gmail.com> wrote:

> With this patch the linker would be using all 3 error handling systems
> in llvm, which is way too much.
> What I think needs to happen is for it to have an Error class that is
> not converted to error_code. We also have to decide if we are keeping
> a list of error or just failing early. I don't think it is worth it
> keeping multiple errors, so I would suggest refactoring the code to
> return early and only store the error when it hits an interface that
> returns void.
> We should also stop logging error to the streamer and instead have the
> caller uses log on the Error.
> The attached patch implements part of that. What do you think?

That all seems reasonable to me. I've updated the revision in phab with a
new patch based on yours that does all of that.

I also moved StringError into the Support library, as it seems like a
useful general facility. Not sure what others think about that.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160526/b97a2eed/attachment.html>

More information about the llvm-commits mailing list