[PATCH] D20019: [PPC] exploitation of new xscmp*, as well as xsmaxcdp and xsmincdp

Ehsan Amiri via llvm-commits llvm-commits at lists.llvm.org
Thu May 26 12:11:18 PDT 2016

amehsan added inline comments.

Comment at: lib/Target/PowerPC/PPC.td:177
@@ -170,1 +176,3 @@
+                                                   "compare, max, and min",
+                                                   [FeatureP9Vector]>;
I think a feature  A should not imply feature B that is a superset of A. I had forgot this point and wrote this code incorrectly, but it seems that "implies" part of a SubtargetFeature has been used incorrectly in features around the new one as well. We probably need to discuss this,  to make sure we are all on the same page. In the meantime I will change my code here. 


More information about the llvm-commits mailing list