[PATCH] D20649: [X86] Add a pattern that uses GR16_ABCD rather than GR32_ABCD to avoid falsely marking whole 32 bit register as live.

David Kreitzer via llvm-commits llvm-commits at lists.llvm.org
Thu May 26 11:53:54 PDT 2016


DavidKreitzer added a comment.

The code change looks reasonable to me Kevin.

-Dave


================
Comment at: test/CodeGen/X86/i16lshr8pat.ll:7
@@ +6,3 @@
+; This test checks to make sure the lshr in %then1 block gets expanded using
+; GR16_ABCD pattern rather than GR32_ABCD pattern.  By using the 16 bit pattern
+; this doesn't make the register liveness information look like the whole 32
----------------
Really picky, but "16 bit" --> "16-bit" and "32 bit" --> "32-bit"


http://reviews.llvm.org/D20649





More information about the llvm-commits mailing list