[PATCH] D20691: AMDGPU: Remove gcc builtin names from workitem intrinsics

Jan Vesely via llvm-commits llvm-commits at lists.llvm.org
Thu May 26 11:36:10 PDT 2016

jvesely added a comment.

In http://reviews.llvm.org/D20691#441248, @arsenm wrote:

> Why do you need this? I know I had a patch to do the same thing at some point, but don't remember why. Since these don't need mangling I would expect GCCBuiltin to work correctly

clang in CodeGenFunction::EmitBuiltinExpr() considers embedded intrinsic names before calling EmitTargetBuiltinExpr(). Since we want these intrinsics to be emitted with range metadata we need to do it in EmitAMDGPUBuiltinExpr(called by EmitTargetBUiltinExpr). The embedded names need to be removed, otherwise the Emit* functions won't run.



More information about the llvm-commits mailing list