[PATCH] D20636: PR26055: Speed up LiveDebugValues::transferDebugValue()

Daniel Berlin via llvm-commits llvm-commits at lists.llvm.org
Thu May 26 11:31:42 PDT 2016

dberlin added inline comments.

Comment at: lib/CodeGen/LiveDebugValues.cpp:261
@@ +260,3 @@
+    unsigned ID = OR->second;
+    OpenRanges.Vars.erase(OR);
+    OpenRanges.VarLocs.reset(ID);
Would you mind simply abstracting this into a openrange class (or something), so that the code to maintain the set/hash happens under the covers and this is just insert/find/erase?

(If this is really difficult or something, feel free to explain why and we can punt :P)



More information about the llvm-commits mailing list