[PATCH] D20688: [ELF][MIPS] Handle section symbol points to the .MIPS.options / .reginfo section

[Rui Ueyama via llvm-commits]

ruiu added inline comments.

================
Comment at: ELF/InputSection.cpp:73-74
@@ +72,4 @@
+    // section. Redirect it to the produced output section.
+    assert(Offset == 0 &&
+           "Retrieve offset in the middle of MIPS reginfo/options section");
+    return this->OutSec->getVA();
----------------
Please use fatal instead of assert because this can be triggered by a broken user input. (use assert only for programmer's (i.e. our) errors.)

================
Comment at: test/ELF/mips-options-r.test:12
@@ +11,3 @@
+#   nop
+# % as -mabi=64 -mips64r2 t.s
+
----------------
Can't you create it using llvm-as?


Repository:
  rL LLVM

http://reviews.llvm.org/D20688