[PATCH] D20578: [esan|wset] Iterate all memory to compute the total working set

Filipe Cabecinhas via llvm-commits llvm-commits at lists.llvm.org
Thu May 26 08:38:23 PDT 2016

filcab accepted this revision.
filcab added a reviewer: filcab.
filcab added a comment.
This revision is now accepted and ready to land.


Comment at: lib/esan/working_set.cpp:35
@@ +34,3 @@
+// Our shadow memory assumes that the line size is 64.
+static const u32 CacheLineSize = 64;
Should this be in the header?

Comment at: lib/esan/working_set.cpp:82
@@ -77,1 +81,3 @@
+// This routine will word-align ShadowStart and ShadowEnd prior to scanning.
+static u32 countAndClearShadowValues(u32 BitIdx, uptr ShadowStart,
We should probably mention it might count and clear a few bytes more than `[ShadowStart,ShadowEnd)`


More information about the llvm-commits mailing list