[PATCH] D20676: [llvm-mc] - Teach llvm-mc to generate zlib styled compression sections.

Rafael Ávila de Espíndola via llvm-commits llvm-commits at lists.llvm.org
Thu May 26 08:07:16 PDT 2016

rafael added inline comments.

Comment at: lib/MC/ELFObjectWriter.cpp:987
@@ +986,3 @@
+// Include the debug info compression header.
+bool ELFObjectWriter::prependCompressionHeader(
+    uint64_t Size, SmallVectorImpl<char> &CompressedContents, bool ZLibStyle,
This function does different things depending on the format

* for zlib it writes the header
* for gnu it prepends the header to CompressedContents

I would be cleaner to rename this to maybeWriteCompression header and have it write the header in both cases.


More information about the llvm-commits mailing list