[PATCH] D20676: [llvm-mc] - Teach llvm-mc to work generate zlib styled compression sections.

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Thu May 26 05:40:43 PDT 2016


grimar added inline comments.

================
Comment at: tools/llvm-mc/llvm-mc.cpp:60
@@ -58,2 +59,3 @@
+  cl::value_desc("compression"));
 
 static cl::opt<bool>
----------------
At first I tried:

```
static cl::opt<DebugCompressionType>
CompressDebugSections("compress-debug-sections", cl::ValueOptional,
  cl::init(DebugCompressionType::DCT_None),
  cl::desc("Choose DWARF debug sections compression:"),
  cl::values(
    clEnumValN(DebugCompressionType::DCT_None, "none",
      "No compression"),
    clEnumValN(DebugCompressionType::DCT_Zlib, "zlib",
      "Use zlib compression"),
    clEnumValN(DebugCompressionType::DCT_Zlib, "zlib-gabi",
      "The same as zlib"),
    clEnumValN(DebugCompressionType::DCT_ZlibGnu, "zlib-gnu",
      "Use zlib-gnu compression (depricated)"),
    clEnumValEnd));
```

But this does not allow just to write "-compress-debug-sections", without 
specifying the value for some reason. Approach that uses std::string works well.


http://reviews.llvm.org/D20676





More information about the llvm-commits mailing list