[PATCH] D19553: Unroll pass restructure.
Evgeny Stupachenko via llvm-commits
llvm-commits at lists.llvm.org
Thu May 26 01:52:40 PDT 2016
evstupac added a comment.
Thank you for the review and accept.
The patch is important for further improvements.
> could we make some named constant for the number of latch-associated instructions and use it instead of putting '2' everywhere?
That's a good point. I'll add a variable for this. However, generally it is not a constant value. It depends on loop instructions and unroll factor. We could have more recurrences to optimize. Say, "s ^= 1" will become constant for every unroll factor which is multiple of 2. I'm going to address this in one of further patches.
More information about the llvm-commits