[PATCH] D20268: [wip] Resolution-based LTO API.

Peter Collingbourne via llvm-commits llvm-commits at lists.llvm.org
Wed May 25 22:03:39 PDT 2016

pcc added inline comments.

Comment at: include/llvm/LTO/LTO.h:259
@@ +258,3 @@
+    /// Partitions generally have a one-to-one correspondence with tasks, except
+    /// that partitions are not split during parallel LTO code generation.
+    size_t Partition = Unknown;
tejohnson wrote:
> should this be "partitions are split during parallel LTO cod generation"? (i.e. remove the "not")
The wording was a little unclear. I wanted to convey that we don't use this field to store the partition number used for parallel LTO code generation. Reworded.

Comment at: include/llvm/LTO/LTO.h:276
@@ +275,3 @@
+  // IRMover and all possible cross-partition references have been seen.
+  StringMap<GlobalResolution> GlobalResolutions;
tejohnson wrote:
> Will this be used for ThinLTO as well? In that case the comment about linking all modules via IRMover doesn't apply. Maybe "cannot be done until all possible cross-partition references have been seen. For regular LTO this is after all modules have been linked by the IRMover and for ThinLTO it is after all summaries have been linked into the combined index." 
Yes, this will also be used for ThinLTO. I have reworded this comment from the client's perspective to make it a little more clear/accurate.


More information about the llvm-commits mailing list