[PATCH] D20642: [codeview] Use comdats for debug info describing comdat functions

Reid Kleckner via llvm-commits llvm-commits at lists.llvm.org
Wed May 25 15:58:58 PDT 2016

rnk marked an inline comment as done.

Comment at: lib/CodeGen/AsmPrinter/CodeViewDebug.h:107
@@ +106,3 @@
+  /// This set tracks which sections we've already opened.
+  SmallPtrSet<MCSectionCOFF *, 4> ComdatDebugSections;
majnemer wrote:
> Hmm, will this really be small for most TUs?
Well, yeah, I expect most TUs have lots of inline functions and I expect this set to get large and go the malloc case. I figure we might as well get out of the linear search small mode and into the hashed malloc mode fairly early. Maybe I should just use DenseSet.


More information about the llvm-commits mailing list