[PATCH] D20388: AMDGPU: Fix supported CL features

Jan Vesely via llvm-commits llvm-commits at lists.llvm.org
Wed May 25 14:51:15 PDT 2016

jvesely planned changes to this revision.
jvesely marked an inline comment as done.
jvesely added a comment.

I'll update this patch based on the outcome of http://reviews.llvm.org/D20447

Comment at: lib/Basic/Targets.cpp:2111
@@ -2110,3 @@
-     Opts.cl_khr_d3d10_sharing = 1;
-     Opts.cl_khr_subgroups = 1;
arsenm wrote:
> What is the current problem with subgroups? There's no reason we can't support this
no problem (other than not implementing any of the required builtins, or exposing cl2.0), since having 1 subgroup per threadgroup is perfectly OK (dunno why this is even an extension).
The bigger question is whether we want to export all potentially available extensions, or only those that are actually implemented.



More information about the llvm-commits mailing list