[PATCH] D20559: [ThinLTO/gold] Handle bitcode archives

[Peter Collingbourne via llvm-commits]

pcc accepted this revision.
pcc added a comment.
This revision is now accepted and ready to land.

LGTM, thanks for testing those things!


================
Comment at: tools/gold/gold-plugin.cpp:522
@@ +521,3 @@
+  if (file->offset)
+    cf.name += ".llvm." + std::to_string(file->offset) + "." +
+               sys::path::filename(Obj->getModule().getSourceFileName()).str();
----------------
Sounds good. As I mentioned before I think at some point we will need to revisit our representation of paths in the index. For save-temps I think we should use some separate mechanism to produce more developer-friendly paths that can be correlated with the index path representation. That does seem low priority for the moment though.


http://reviews.llvm.org/D20559