[PATCH] D20558: [LibFuzzer] Start cleaning up the CMakeLists.txt files.

Kostya Serebryany via llvm-commits llvm-commits at lists.llvm.org
Wed May 25 13:12:49 PDT 2016

kcc added a comment.

This is rather confusing. I stopped understanding why you are doing this and it looks like you are trying to solve several problems at once.

try to

- split this patch into several, each patch solving just one problem  (if possible)
- make the cmake files smaller, not bigger
- avoid non-actionable FIXMEs

Comment at: lib/Fuzzer/CMakeLists.txt:10
@@ +9,3 @@
+    "-fno-sanitize=all"
+    # FIXME: gcc doesn't know this flag
+    "-fno-sanitize-coverage=edge,trace-cmp,indirect-calls,8bit-counters"
Why is this FIXME? Do you expect to implement these flags in gcc? 

Comment at: lib/Fuzzer/CMakeLists.txt:13
@@ -5,1 +12,3 @@
+    "-Werror")
+  # FIXME: Test the compiler supports those flags
   add_library(LLVMFuzzerNoMainObjects OBJECT
Do you really need this FIXME?  (up to you, just asking) 

Comment at: lib/Fuzzer/test/CMakeLists.txt:34
@@ +33,3 @@
+  foreach (flag ${BUILD_FLAGS_AS_LIST})
+    # FIXME: Use of XX here is to avoid CMP0054
+    if (NOT ("XX${flag}" MATCHES "XX-O[0123s]"))
Do you need this FIXME> 

Comment at: lib/Fuzzer/test/CMakeLists.txt:110
@@ -70,1 +109,3 @@
+  target_compile_options(LLVMFuzzer-${Test} PRIVATE ${SANITIZE_COVERAGE_FLAGS})
+  llvm_append_linker_flag(LLVMFuzzer-${Test} ${SANITIZE_COVERAGE_FLAGS})
This sucks. It really makes the file much bigger. Is that the only way? 


More information about the llvm-commits mailing list