[PATCH] D20178: Fix PR26055 - LiveDebugValues is very slow

Daniel Berlin via llvm-commits llvm-commits at lists.llvm.org
Wed May 25 13:11:01 PDT 2016


dberlin added a comment.

LGTM


================
Comment at: lib/CodeGen/LiveDebugValues.cpp:55
@@ +54,3 @@
+  // indirecltly), this register is always a first operand.
+  return MI.getOperand(0).isReg() ? MI.getOperand(0).getReg() : 0;
+}
----------------
Nit: indirectly

================
Comment at: lib/CodeGen/LiveDebugValues.cpp:103
@@ +102,3 @@
+      } RegisterLoc;
+      uint64_t Hash;
+    } Loc;
----------------
Errr, do you really never use the hash and the registerloc at the same time?



http://reviews.llvm.org/D20178





More information about the llvm-commits mailing list