[PATCH] D20456: [CodeGen] Fix problem with X86 byte registers in CriticalAntiDepBreaker

Quentin Colombet via llvm-commits llvm-commits at lists.llvm.org
Wed May 25 10:52:27 PDT 2016


qcolombet added a comment.

Apparently I forgot to push submit!


================
Comment at: test/CodeGen/X86/pr27681.ll:5
@@ +4,3 @@
+; erroneously choose an unavailable byte register to break a dependence.
+; The test is of course highly dependent on register allocation.
+ at c = global i16 4, align 2
----------------
I would recommend to use a MIR test instead.
That way we do not need to be (un)lucky with the register allocation. Moreover the test should be much smaller and easier to understand that way.


http://reviews.llvm.org/D20456





More information about the llvm-commits mailing list