[PATCH] D20622: [ELF] - Added support for jmp/call relaxations when R_X86_64_GOTPCRELX/R_X86_64_REX_GOTPCRELX are used.

[Rafael Ávila de Espíndola via llvm-commits]

rafael accepted this revision.
rafael added a comment.
This revision is now accepted and ready to land.

LGTM with nit.


================
Comment at: ELF/Target.cpp:764
@@ +763,3 @@
+  // We can convert jmp and call, other instructions are not yet supported.
+  if (Op != 0xff)
+    return;
----------------
Make this an assert, since we only got here if canRelaxGot returned true.

================
Comment at: ELF/Target.cpp:774
@@ +773,3 @@
+  } else {
+    // ModRm == 0x25.
+    // Convert jmp *foo at GOTPCREL(%rip) to jmp foo nop.
----------------
Replace comment with assert.



http://reviews.llvm.org/D20622