[llvm] r270667 - Revert "llvm-objdump: support dumping AUX records for weak externals"

Saleem Abdulrasool via llvm-commits llvm-commits at lists.llvm.org
Tue May 24 22:45:02 PDT 2016


Author: compnerd
Date: Wed May 25 00:45:02 2016
New Revision: 270667

URL: http://llvm.org/viewvc/llvm-project?rev=270667&view=rev
Log:
Revert "llvm-objdump: support dumping AUX records for weak externals"

Revert it until we can figure out the endianness issue.

Removed:
    llvm/trunk/test/Object/Inputs/COFF/weak-externals.yaml
    llvm/trunk/test/Object/coff-weak-externals.test
Modified:
    llvm/trunk/tools/llvm-objdump/COFFDump.cpp

Removed: llvm/trunk/test/Object/Inputs/COFF/weak-externals.yaml
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Object/Inputs/COFF/weak-externals.yaml?rev=270666&view=auto
==============================================================================
--- llvm/trunk/test/Object/Inputs/COFF/weak-externals.yaml (original)
+++ llvm/trunk/test/Object/Inputs/COFF/weak-externals.yaml (removed)
@@ -1,26 +0,0 @@
----
-header:
-  Machine:         IMAGE_FILE_MACHINE_ARMNT
-  Characteristics: [  ]
-sections:
-  - Name:            .rdata
-    Characteristics: [ IMAGE_SCN_CNT_INITIALIZED_DATA, IMAGE_SCN_MEM_READ ]
-    Alignment:       1
-    SectionData:     ''
-symbols:
-  - Name:            Function
-    Value:           0
-    SectionNumber:   0
-    SimpleType:      IMAGE_SYM_TYPE_NULL
-    ComplexType:     IMAGE_SYM_DTYPE_NULL
-    StorageClass:    IMAGE_SYM_CLASS_WEAK_EXTERNAL
-    WeakExternal:
-      TagIndex:        9
-      Characteristics: IMAGE_WEAK_EXTERN_SEARCH_LIBRARY
-  - Name:            .weak.Function.default
-    Value:           0
-    SectionNumber:   -1
-    SimpleType:      IMAGE_SYM_TYPE_NULL
-    ComplexType:     IMAGE_SYM_DTYPE_NULL
-    StorageClass:    IMAGE_SYM_CLASS_EXTERNAL
-...

Removed: llvm/trunk/test/Object/coff-weak-externals.test
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Object/coff-weak-externals.test?rev=270666&view=auto
==============================================================================
--- llvm/trunk/test/Object/coff-weak-externals.test (original)
+++ llvm/trunk/test/Object/coff-weak-externals.test (removed)
@@ -1,5 +0,0 @@
-RUN: llvm-objdump -t %p/Inputs/COFF/weak-externals.obj | FileCheck %s
-
-CHECK: [ 0](sec  0)(fl 0x00)(ty   0)(scl  69) (nx 1) 0x00000000 Function
-CHECK: AUX tagndx 9 type 2
-

Modified: llvm/trunk/tools/llvm-objdump/COFFDump.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-objdump/COFFDump.cpp?rev=270667&r1=270666&r2=270667&view=diff
==============================================================================
--- llvm/trunk/tools/llvm-objdump/COFFDump.cpp (original)
+++ llvm/trunk/tools/llvm-objdump/COFFDump.cpp Wed May 25 00:45:02 2016
@@ -653,12 +653,6 @@ void llvm::printCOFFSymbolTable(const CO
 
         SI = SI + Symbol->getNumberOfAuxSymbols();
         break;
-      } else if (Symbol->isWeakExternal()) {
-        const coff_aux_weak_external *awe;
-        error(coff->getAuxSymbol<coff_aux_weak_external>(SI + 1, awe));
-
-        outs() << "AUX " << format("tagndx %d type %d\n", awe->TagIndex,
-                                   awe->Characteristics);
       } else {
         outs() << "AUX Unknown\n";
       }




More information about the llvm-commits mailing list