[PATCH] D20337: [MC] Support symbolic expressions in assembly directives

Nirav Dave via llvm-commits llvm-commits at lists.llvm.org
Tue May 24 20:50:05 PDT 2016

niravd added inline comments.

Comment at: lib/MC/MCAsmStreamer.cpp:828
@@ +827,3 @@
+  MCStreamer::emitFill(NumBytes, FillValue);
I believe it still is. Consider the case where the symbolic expression emitted for NumBytes is eventually evaluated to a non-positive number or is invalid? Errors in the compilation of the output assembly would point to location in the output asm file not the original as it should. 



More information about the llvm-commits mailing list