[PATCH] D20558: [LibFuzzer] Start cleaning up the CMakeLists.txt files.

Dan Liew via llvm-commits llvm-commits at lists.llvm.org
Tue May 24 16:55:10 PDT 2016

delcypher added inline comments.

Comment at: lib/Fuzzer/test/CMakeLists.txt:35
@@ +34,3 @@
+    # FIXME: Use of XX here is to avoid CMP0054
+    if (NOT ("XX${flag}" MATCHES "XX-O[0123s]"))
+      set(new_flags "${new_flags} ${flag}")
@aizatsky. It should be provided

* The compiler is gcc/clang - We have a hard requirement on Clang anyway so this is fine.
* LLVM hasn't previously modified the CMAKE_CXX_FLAGS_* from their default. AFAICT this holds too as LLVM usually modifies CMAKE_CXX_FLAGS rather than the release specific variables.

If you like I could put in a check for this assumption so we throw an error if this assumption doesn't hold.


More information about the llvm-commits mailing list