[PATCH] D20455: [asan] Enable asan Win64 build
Reid Kleckner via llvm-commits
llvm-commits at lists.llvm.org
Tue May 24 15:29:41 PDT 2016
rnk added a comment.
Functionally this is fine. Etienne, can you commit this on behalf of Wei after the comment stuff is addressed?
Comment at: lib/sanitizer_common/sanitizer_atomic_msvc.h:179
@@ +178,3 @@
+ // TODO: implement same functionality without inline asm
+ // Inline asm not supported in Win64
Can you capitalize your comment sentence starts and end them with a period? Sorry I forgot to raise that earlier.
More information about the llvm-commits