[PATCH] D20541: [esan|cfrag] Create the cfrag variable for the runtime

Mike Aizatsky via llvm-commits llvm-commits at lists.llvm.org
Tue May 24 14:16:47 PDT 2016

aizatsky added inline comments.

Comment at: lib/Transforms/Instrumentation/EfficiencySanitizer.cpp:199
@@ +198,3 @@
+// Create the global variable for the cache-fragmentation tool.
+GlobalVariable *EfficiencySanitizer::createCacheFragGV(Module &M) {
+  assert(Options.ToolType == EfficiencySanitizerOptions::ESAN_CacheFrag);
What I meant: maybe there should be "createToolGV" that would be used for all efficiency sanitizers? Do you think that work set tool will need a different layout of this variable? Maybe it is something you don't have to specialize, but keep generic instead?


More information about the llvm-commits mailing list