[PATCH] D20262: [DSE]Split memset when the memset is small enough to be lowered to stores

Daniel Berlin via llvm-commits llvm-commits at lists.llvm.org
Tue May 24 12:59:30 PDT 2016


dberlin added a comment.

So, in terms of high level optimization, this looks correct at a glance.
I'd wait for quentin to say whether he thinks this makes sense for LLVM's backends.
Assuming he thinks it looks good on that front, looks good to me.


================
Comment at: lib/Transforms/Scalar/DeadStoreElimination.cpp:238
@@ +237,3 @@
+
+  if (MaxIntSize == 0)
+    MaxIntSize = 1;
----------------
How and when can this happen?


http://reviews.llvm.org/D20262





More information about the llvm-commits mailing list