[PATCH] D20488: [esan] Add calls from the ctor/dtor to the runtime library

Qin Zhao via llvm-commits llvm-commits at lists.llvm.org
Tue May 24 12:35:47 PDT 2016


zhaoqin added inline comments.

================
Comment at: lib/Transforms/Instrumentation/EfficiencySanitizer.cpp:186
@@ +185,3 @@
+  // FIXME: create the tool specific global variable.
+  if (GV == nullptr) {
+    GV = new GlobalVariable(M, IntptrTy, true, GlobalVariable::InternalLinkage,
----------------
zhaoqin wrote:
> vitalybuka wrote:
> > this is always nullptr
> yes, xref the FIXME above. tool specific global variable to be added.
> Next CL adds tool specific global variable creation, waiting for this CL to be landed before sending the next one.
http://reviews.llvm.org/D20541


http://reviews.llvm.org/D20488





More information about the llvm-commits mailing list