[PATCH] D20572: [profile] clean up file handling code

David Li via llvm-commits llvm-commits at lists.llvm.org
Tue May 24 12:07:51 PDT 2016

davidxl marked 5 inline comments as done.

Comment at: lib/profile/InstrProfilingFile.c:112-117
@@ -102,3 +111,8 @@
-static void setFilename(const char *Filename, int OwnsFilename) {
+/* Set the result of the file name parsing. If \p FilenamePat pattern is seen
+ * the first time, also truncate the file associated with that name.
+ */
+static void setFilename(const char *FilenamePat, const char *PidStr,
+                        unsigned NumPids, const char *HostStr,
+                        unsigned NumHosts) {
   /* Check if this is a new filename and therefore needs truncation. */
there is no change. If the pattern str changes, the filename will also change which requires truncation in previous implementation.


More information about the llvm-commits mailing list