[PATCH] D20571: [BPF] Remove exit-on-error flag in test (PR27767)

Alexei Starovoitov via llvm-commits llvm-commits at lists.llvm.org
Tue May 24 11:06:49 PDT 2016

ast requested changes to this revision.
This revision now requires changes to proceed.

Comment at: lib/Target/BPF/BPFISelLowering.cpp:202
@@ -201,2 +201,3 @@
       fail(DL, DAG, "defined with too many args");
+      InVals.push_back(DAG.getUNDEF(MVT::Other));
bpf backend doesn't like 'undef' since most likely it would mean that generated code will be reject by the kernel verifier with hard to decipher error. Can you change it to use const zero instead? In general continuing after "too many args" is hard. At least with zero there is a chance that generated code is somewhat sane.


More information about the llvm-commits mailing list