[PATCH] D20290: [ThinLTO] Change ODR resolution and internalization to be index-based

Mehdi AMINI via llvm-commits llvm-commits at lists.llvm.org
Tue May 24 09:33:33 PDT 2016

joker.eph added inline comments.

Comment at: lib/LTO/ThinLTOCodeGenerator.cpp:339
@@ -344,2 +338,3 @@
+  }
tejohnson wrote:
> joker.eph wrote:
> > Yes in ld64 and regular monolithic LTO, we are internalizing linkonce_ODR if they are not exported.
> > Can weak functions defined in the main binary be overriden at runtime?
> > It may be a platform specific question...
> > 
> Agree it is going to be platform specific. So then I think that the new version of the patch is better, and each linker will need to handle appropriately (e.g. here by adding to preserveSymbol(), in gold by using the callback to query gold's resolution, and eventually with pcc's API via the resolution info provided to the API).
> Do you want to retest this new version before I commit?
No it should be fine (and I have a bot that will bootstrap clang immediately anyway)


More information about the llvm-commits mailing list