[PATCH] D20270: libc++abi: build with -fvisibility=default

Eric Fiselier via llvm-commits llvm-commits at lists.llvm.org
Mon May 23 21:36:04 PDT 2016

EricWF added a comment.

So the first three symbols mentioned need to be reexported. See https://llvm.org/bugs/show_bug.cgi?id=23238 for a related bug.
They are listed as part of the spec in "spec.html" and we shouldn't change that now.
Better safe than sorry especially when managing the ABI.

You noted that  `__cxa_throw_bad_array_new_length` and  `__cxa_uncaught_exceptions` are added on OS X, but that is true before this change as well (when comparing to the system library).

I'm not really concerned with the basic_string methods that go away. The symbols are also exported by libc++.so and so they should always be present anyway.



More information about the llvm-commits mailing list