[PATCH] D15779: [ELF] - Implemented optimization for R_X86_64_GOTPCREL relocation.

Rafael Ávila de Espíndola via llvm-commits llvm-commits at lists.llvm.org
Mon May 23 16:36:49 PDT 2016


rafael added inline comments.

================
Comment at: ELF/Writer.cpp:535
@@ +534,3 @@
+  if (Target->canRelaxGot(Type, Body, Data, Offset))
+    return R_RELAX_GOT;
+
----------------
I don't think you can do an early return here. You should set Expr and let the function continue so we get the checks.


http://reviews.llvm.org/D15779





More information about the llvm-commits mailing list