[PATCH] D20403: Search for llvm-symbolizer binary in same directory as argv
Reid Kleckner via llvm-commits
llvm-commits at lists.llvm.org
Mon May 23 16:08:50 PDT 2016
rnk added inline comments.
Comment at: lib/Support/Signals.cpp:85-86
@@ +84,4 @@
+ StringRef Parent = llvm::sys::path::parent_path(Argv0);
+ if (Parent.empty())
+ Parent = ".";
+ sys::findProgramByName("llvm-symbolizer", Parent);
So, if 'clang' was on PATH, argv0 would be 'clang', parent_path will return an empty string, and then we'll try './llvm-symbolizer'? Are you sure that's what we want? Maybe just skip to the PATH search in that case?
More information about the llvm-commits