[PATCH] D20220: [PEI, AArch64] Use empty spaces in stack area for local stack slot allocation.

Geoff Berry via llvm-commits llvm-commits at lists.llvm.org
Mon May 23 11:53:45 PDT 2016

gberry added a comment.

Hi Quentin,

Thanks for the review.  I believe I've addressed all of the issues you raised, if not just let me know.

@t.p.northover Are you okay with the AArch64 specific changes?

Comment at: lib/CodeGen/PrologEpilogInserter.cpp:925
@@ -812,3 +924,3 @@
            IE = SFIs.end(); I != IE; ++I)
       AdjustStackOffset(MFI, *I, StackGrowsDown, Offset, MaxAlign, Skew);
Wow, that was a particularly bad typo :)

Comment at: test/CodeGen/AArch64/aarch64-dynamic-stack-layout.ll:681
@@ -680,3 +680,3 @@
   %MyAlloca = alloca i8, i64 64, align 32
   br label %bb1
After my change, %tmp was getting placed in a hole in the Fixed/CS stack area, leading to no local stack space being allocated in the prologue, which ended up hiding the problem this test was checking for without actually fixing it.  I made the change smaller in this revision by simply making %tmp bigger so it wouldn't fit in the unused part of the Fixed/CS stack area any more.


More information about the llvm-commits mailing list