[PATCH] D20470: [llvm-dwarfdump] - Teach dwarfdump to decompress debug sections in zlib style.

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Mon May 23 02:10:26 PDT 2016

>Except this defeats/comes at a cost of the small vector optimization - std::move on a small vector in small mode is the same as a copy.

>Sorry, perhaps I should've commented the original code to explain/justify it better.
>- David

Small mode for small vector in this place is when it's size less than 32 bytes, right ?
Should we really care of this for the sake of simplicity of code ? I mean that for debug sections 32 bytes
is probably almost never a option, they usually should be greater anyways I think.

Just in case - I plan to revert to initial logic of this soon and update the patch, as it does not affect the main logic
and we can land patch separatelly and return to this place later if we want to.?

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160523/4ebe321b/attachment.html>

More information about the llvm-commits mailing list