[PATCH] D20273: [llvm-readobj] - Teach readobj to recognize SHF_COMPRESSED flag.

[Davide Italiano via llvm-commits]

davide added a comment.

I'm still convinced (for many reasons) that checking in a binary isn't a great option when we can use MC.
I don't think "excessive dependencies like asm->llvm-mc->zlib" is a strong argument as we have them anyway.
OTOH, using our tools instead of a binary allows:

1. dogfooding (which might catch regression)
2. easier changes in case something breaks in the toolchain (we don't need to generate the binary again, we can just change the test)
3. readability (you can read the ASM instead of a description). Maybe it's not the case but from time to time precompiled binaries lack a comment which describes how they've been generated, and comments and binary can get out of sync quickly.

In other words, I'm always for using llvm-mc instead of a binary (unless there's a strong reason not to). I'd rather bit the bullet and implement the missing feature in the assembler instead of going through the binary route which may lead to bigger pain later (I had to generate again ~10 binaries in DebugInfo tests in order to fix a bug in the verifier recently).


Repository:
  rL LLVM

http://reviews.llvm.org/D20273