[PATCH] D20002: Fix Bug 11740: Turn off -g when there are directive file debug info

[David Blaikie via llvm-commits]

dblaikie added inline comments.

================
Comment at: test/MC/AsmParser/directive_file-2.s:2
@@ +1,3 @@
+# RUN: llvm-mc -triple i386-unknown-unknown %s | FileCheck %s
+# RUN: llvm-mc -triple i386-unknown-unknown %s -filetype=null
+// Test for Bug 11740
----------------
zhizhouy wrote:
> zhizhouy wrote:
> > dblaikie wrote:
> > > What's this second run line for?
> > Just to run twice with different command line options for stability. The same as what
> > is in the test/MC/AsmParser/directive_file.s
> In fact I am not quite familiar with the other test case (directive_file.s),
> it seems it has these two lines to face two different situations.
> 
> So I just reused it since this test case should also work as the same as 
> the former one.
I'd rather not cargo cult the test in - if we don't know why it's there, could you leave it out?

================
Comment at: test/MC/AsmParser/directive_file-2.s:3
@@ +2,3 @@
+# RUN: llvm-mc -triple i386-unknown-unknown %s -filetype=null
+// Test for Bug 11740
+
----------------
Might be worth describing what the behavior/issue is that's being tested here.


http://reviews.llvm.org/D20002