[llvm] r270248 - [MachOYAML] Removing duplicated field from LC_UUID YAML

Chris Bieneman via llvm-commits llvm-commits at lists.llvm.org
Fri May 20 11:37:01 PDT 2016


Author: cbieneman
Date: Fri May 20 13:36:52 2016
New Revision: 270248

URL: http://llvm.org/viewvc/llvm-project?rev=270248&view=rev
Log:
[MachOYAML] Removing duplicated field from LC_UUID YAML

The uuid_command was duplicating the load_command.cmdsize field. This removes the duplicate from the YAML mapping and from the test cases.

Modified:
    llvm/trunk/lib/ObjectYAML/MachOYAML.cpp
    llvm/trunk/test/ObjectYAML/MachO/load_commands.yaml
    llvm/trunk/test/ObjectYAML/MachO/sections.yaml

Modified: llvm/trunk/lib/ObjectYAML/MachOYAML.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/ObjectYAML/MachOYAML.cpp?rev=270248&r1=270247&r2=270248&view=diff
==============================================================================
--- llvm/trunk/lib/ObjectYAML/MachOYAML.cpp (original)
+++ llvm/trunk/lib/ObjectYAML/MachOYAML.cpp Fri May 20 13:36:52 2016
@@ -439,7 +439,6 @@ void MappingTraits<MachO::twolevel_hints
 void MappingTraits<MachO::uuid_command>::mapping(
     IO &IO, MachO::uuid_command &LoadCommand) {
 
-  IO.mapRequired("cmdsize", LoadCommand.cmdsize);
   IO.mapRequired("uuid", LoadCommand.uuid);
 }
 

Modified: llvm/trunk/test/ObjectYAML/MachO/load_commands.yaml
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/ObjectYAML/MachO/load_commands.yaml?rev=270248&r1=270247&r2=270248&view=diff
==============================================================================
--- llvm/trunk/test/ObjectYAML/MachO/load_commands.yaml (original)
+++ llvm/trunk/test/ObjectYAML/MachO/load_commands.yaml Fri May 20 13:36:52 2016
@@ -98,7 +98,6 @@ LoadCommands:
     name:            12
   - cmd:             LC_UUID
     cmdsize:         24
-    cmdsize:         24
     uuid:            461A1B28-822F-3F38-B670-645419E636F5
   - cmd:             LC_VERSION_MIN_MACOSX
     cmdsize:         16
@@ -225,7 +224,6 @@ LoadCommands:
 #CHECK:     name:            12
 #CHECK:   - cmd:             LC_UUID
 #CHECK:     cmdsize:         24
-#CHECK:     cmdsize:         24
 #CHECK:     uuid:            461A1B28-822F-3F38-B670-645419E636F5
 #CHECK:   - cmd:             LC_VERSION_MIN_MACOSX
 #CHECK:     cmdsize:         16

Modified: llvm/trunk/test/ObjectYAML/MachO/sections.yaml
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/ObjectYAML/MachO/sections.yaml?rev=270248&r1=270247&r2=270248&view=diff
==============================================================================
--- llvm/trunk/test/ObjectYAML/MachO/sections.yaml (original)
+++ llvm/trunk/test/ObjectYAML/MachO/sections.yaml Fri May 20 13:36:52 2016
@@ -208,7 +208,6 @@ LoadCommands:
     name:            12
   - cmd:             LC_UUID
     cmdsize:         24
-    cmdsize:         24
     uuid:            461A1B28-822F-3F38-B670-645419E636F5
   - cmd:             LC_VERSION_MIN_MACOSX
     cmdsize:         16




More information about the llvm-commits mailing list