[llvm] r269969 - When looking for a spill slot in reg scavenger, find one that matches RC

[Krzysztof Parzyszek via llvm-commits]

On 5/20/2016 1:32 PM, Quentin Colombet wrote:
> This is UB, that probably means we can find a case where this is not
> making the compiler aborting (or at least not with a “nice” message).
> Therefore, I would recommend to stick to report_fatal_error for that case.
>
> What do people think?

That we should stop using it as an equivalent to assert(false && "...").

There is a value in having "unreachable" as a hint to the compiler that 
allows it to optimize the code more aggressively, but we should still 
have a way to terminate the compiler due to an abnormal situation 
detected (internal compiler error) regardless of the build type.

-Krzysztof


-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, 
hosted by The Linux Foundation