[PATCH] D20299: AMDGPU: Export target workitem related builtins

Matt Arsenault via llvm-commits llvm-commits at lists.llvm.org
Fri May 20 10:35:32 PDT 2016


arsenm added inline comments.

================
Comment at: include/clang/Basic/BuiltinsAMDGPU.def:79
@@ +78,3 @@
+
+LANGBUILTIN(__builtin_r600_read_workdim, "Ui", "nc", OCLC_LANG)
+
----------------
These shouldn't be lang builtin, I just meant the commit message said so

================
Comment at: test/CodeGenOpenCL/builtins-amdgcn.cl:280
@@ +279,3 @@
+// CHECK-LABEL: @test_get_group_id(
+// CHECK: tail call i32 @llvm.amdgcn.workgroup.id.x()
+// CHECK: tail call i32 @llvm.amdgcn.workgroup.id.y()
----------------
range metadata check?


Repository:
  rL LLVM

http://reviews.llvm.org/D20299





More information about the llvm-commits mailing list